Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
==========================================
+ Coverage 71.40% 71.59% +0.19%
==========================================
Files 206 206
Lines 15057 15057
==========================================
+ Hits 10751 10780 +29
+ Misses 3523 3491 -32
- Partials 783 786 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
Contributor
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
eguguchkin
requested review from
dkharms,
eguguchkin and
forshev
and removed request for
eguguchkin
forshev
approved these changes
Mar 16, 2026
eguguchkin
reviewed
Mar 16, 2026
node/bench_test.go
Outdated
| n := NewOr(newNodeStaticSize(s), newNodeStaticSize(s), false) | ||
| n := NewOr(newNodeStaticSize(r, s), newNodeStaticSize(r, s), false) | ||
|
|
||
| b.ResetTimer() |
Contributor
There was a problem hiding this comment.
I think Loop itself takes care of resetting the timer.
eguguchkin
approved these changes
Mar 16, 2026
Contributor
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
Contributor
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use const seed and call
ResetTimer. They false report degradation too often, but it's possible to slow down on them actually.